Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cli module refactoring #1607

Merged
merged 11 commits into from
Apr 10, 2024
Merged

Feature/cli module refactoring #1607

merged 11 commits into from
Apr 10, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Feb 23, 2024 •
edited
Loading

Contains a big refactoring of the cli module. In specific:

  • Minor refactoring all over the module based on Intellijs code analysis.
  • A rewrite of the CollectedLogger class, because the base interface we used is deprecated since 2020.
  • The CLI class has been split up into multiple classes.

@TwoOfTwelve
Copy link
Contributor Author

The three remaining sonarcloud issues already existed and cannot be fixed. Unless we want to remove the legacy support for the old submission directories.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Feb 26, 2024
@tsaglam tsaglam requested a review from a team March 12, 2024 14:51
@TwoOfTwelve
Copy link
Contributor Author

@tsaglam could you take another look at this?

@TwoOfTwelve TwoOfTwelve requested a review from uuqjz April 2, 2024 14:21
uuqjz
uuqjz approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks got to me.

cli/src/main/java/de/jplag/cli/picocli/CliInputHandler.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CLI.java Show resolved Hide resolved
tsaglam
tsaglam reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that the CLI help text and the log output during the run is not changed?

@TwoOfTwelve
Copy link
Contributor Author

I have tested it with a short example. The formatting of the log output might have changed slightly, but the content is definitely still the same.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
68.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit d4b2dc3 into develop Apr 10, 2024
35 checks passed
@tsaglam tsaglam deleted the feature/cli-module-refactoring branch April 10, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uuqjz uuqjz uuqjz approved these changes

@tsaglam tsaglam tsaglam approved these changes

@Kr0nox Kr0nox Awaiting requested review from Kr0nox

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoOfTwelve @tsaglam @uuqjz