Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused DirectoryManager #1573

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

TwoOfTwelve
Copy link
Contributor

Removed the unused DirectoryManager class. It was used to zip the result directory and has become unused with #1416.

@tsaglam If you want me to, I can move the log-messages somewhere else, but I think with the local mode they are obsolete too, except maybe the file location.

@tsaglam
Copy link
Member

tsaglam commented Feb 20, 2024

If you want me to, I can move the log-messages somewhere else, but I think with the local mode they are obsolete too, except maybe the file location.

As local mode is not default for now, I would prefer to keep the messages until it does.

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Feb 20, 2024
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit 0388a2a into develop Feb 20, 2024
9 checks passed
@tsaglam tsaglam deleted the feature/remove-directory-manager branch February 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants