Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling and logging of the language modules #1572

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Improve error handling and logging of the language modules #1572

merged 4 commits into from
Feb 20, 2024

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Feb 20, 2024 •
edited
Loading

  • More structure and less clutter for all language module error logging
  • Specific improvements to the Java language module (deduplication + readability)
  • Avoid logging loaded languages

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Feb 20, 2024
@tsaglam tsaglam changed the base branch from main to develop February 20, 2024 10:40
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues

Measures
0 Security Hotspots
91.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam marked this pull request as ready for review February 20, 2024 10:50
@tsaglam tsaglam requested review from a team February 20, 2024 10:50
@tsaglam tsaglam merged commit bd92e73 into develop Feb 20, 2024
9 checks passed
@tsaglam tsaglam deleted the feature/error-handling branch February 20, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoOfTwelve TwoOfTwelve TwoOfTwelve approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsaglam @TwoOfTwelve