Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in the creation of the result due to missing slashes. #1568

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

For source roots without sub-directories, the files in the results.zip had the wrong name, because there was a slash missing.

@TwoOfTwelve TwoOfTwelve requested review from tsaglam, Kr0nox and uuqjz and removed request for tsaglam February 16, 2024 13:00
Copy link
Contributor

@uuqjz uuqjz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues are solved

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Feb 16, 2024
@TwoOfTwelve TwoOfTwelve added this to the v5.0.0 milestone Feb 16, 2024
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question.

core/src/main/java/de/jplag/reporting/FilePathUtil.java Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam tsaglam merged commit eaea554 into develop Feb 20, 2024
9 checks passed
@tsaglam tsaglam deleted the bug/submissionFilePathsMissingSlash branch February 20, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants