Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed cpp to c and cpp2 to cpp #1496

Merged
merged 12 commits into from
Feb 15, 2024
Merged

Renamed cpp to c and cpp2 to cpp #1496

merged 12 commits into from
Feb 15, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

Renamed cpp to c and cpp2 to cpp as discussed.

@TwoOfTwelve TwoOfTwelve requested review from Kr0nox and tsaglam and removed request for Kr0nox January 30, 2024 14:33
@tsaglam
Copy link
Member

tsaglam commented Jan 31, 2024

@TwoOfTwelve can you add a readme for the C module that mentions that it was formerly the cpp language module as in JPlag versions pre 5.0.0.

@Kr0nox
Copy link
Member

Kr0nox commented Jan 31, 2024

And update the README of the now cpp (formerly cpp2) module, since it still mentions the module as cpp2

tsaglam
tsaglam requested changes Feb 2, 2024
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the language table in the main readme, add a readme to c, update the cpp readme, and check if the wiki needs to be updated.

report-viewer/src/model/Language.ts Outdated Show resolved Hide resolved
languages/c/src/main/java/de/jplag/c/CLanguage.java Outdated Show resolved Hide resolved
languages/cpp/src/main/java/de/jplag/cpp/CPPLanguage.java Outdated Show resolved Hide resolved
TwoOfTwelve and others added 3 commits February 2, 2024 11:01
@TwoOfTwelve @tsaglam
Simplified C / CPP names
faf05ca 
Co-authored-by: Timur Sağlam <[email protected]>
@TwoOfTwelve @tsaglam
Simplified C / CPP names
0e6a23a 
Co-authored-by: Timur Sağlam <[email protected]>
@TwoOfTwelve @tsaglam
Simplified C / CPP names
34e34e8 
Co-authored-by: Timur Sağlam <[email protected]>
@TwoOfTwelve
Copy link
Contributor Author

@Kr0nox can you take a look at the conflict here? I assume we only need to accept the incoming changes, but as I don't know the code I don't just want to commit it.

@tsaglam
Copy link
Member

tsaglam commented Feb 2, 2024

@TwoOfTwelve since sonar is back, we have a few issues here. Also don't forget my comments regarding the readme files.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Feb 13, 2024
Kr0nox
Kr0nox requested changes Feb 13, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
languages/cpp/README.md Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 13, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues

Measures
0 Security Hotspots
54.5% Coverage on New Code
4.8% Duplication on New Code

See analysis details on SonarCloud

@Kr0nox Kr0nox added this to the v5.0.0 milestone Feb 13, 2024
@tsaglam
Copy link
Member

tsaglam commented Feb 15, 2024

@Kr0nox ready from your side?

@tsaglam tsaglam merged commit a5705bb into develop Feb 15, 2024
17 checks passed
@tsaglam tsaglam deleted the feature/cpp-module-names branch February 15, 2024 08:40
@Kr0nox Kr0nox mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kr0nox Kr0nox Kr0nox approved these changes

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoOfTwelve @tsaglam @Kr0nox