Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a better error message, if no valid language was supplied. #1493

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Jan 19, 2024

I an invalid language was supplied on the cli the following message is now printed:

Language asdf does not exists. Available languages are: cpp, cpp2, csharp, emf, emf-model, go, java, kotlin, llvmir, python3, rlang, rust, scala, scheme, scxml, swift, text, typescript

@TwoOfTwelve TwoOfTwelve requested review from tsaglam and Kr0nox and removed request for tsaglam January 19, 2024 10:39
@Kr0nox
Copy link
Member

Kr0nox commented Jan 21, 2024

With this we could also rethink the available languages message printed at the start

 LanguageLoader - Available languages: '[C/C++ Scanner [basic markup], C/C++ Parser, C# 6 Parser, EMF metamodel, EMF models (dynamically created token set), Go Parser, Javac based AST plugin, Kotlin Parser, LLVMIR Parser, Python3 Parser, R Parser, Rust Language Module, Scala parser, SchemeR4RS Parser [basic markup], SCXML (Statechart XML), Swift Parser, Text Parser (naive), Typescript Parser]'

Since these are the available parsers, not languages as stated in the message. and with #1494 we have two languages that use the same parser and that new language would not be explicitly mentioned in this message

@tsaglam tsaglam merged commit 3c9af11 into develop Jan 22, 2024
8 checks passed
@tsaglam tsaglam deleted the feature/cli-invalid-language-error-message branch January 22, 2024 09:24
@tsaglam
Copy link
Member

tsaglam commented Jan 22, 2024

@Kr0nox the language loader should check for language interface implementations, and thus the Javascript module should be mentioned when the dependency in the CLI module ist set...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants