Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comparison single file upload #1492

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jan 18, 2024

Currently JPlag supports uploading a single comparison file json and then navigates to the comparison view. This can not work since the files of the submission are missing. Because of this this PR removes it.

The single file upload for overview files is untouched

@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Jan 18, 2024
@Kr0nox Kr0nox requested a review from sebinside January 18, 2024 16:02
Copy link

sonarcloud bot commented Jan 18, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, thank you. If easily possible, we could think about showing a clearer error message when only dropping an overview.json. As this feature will soon not be required anyway, it's also fine as is.

@sebinside sebinside merged commit ad664c6 into develop Jan 22, 2024
16 checks passed
@sebinside sebinside deleted the report-viewer/fix-single-upload branch January 22, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants