Improve cluster sorting speed #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
added
the
report-viewer
|
[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!
|
tsaglam
added
bug
tsaglam
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the speed of the cluster sorting.
Previously it was slow, because when it was enabled, the report-viewer iterated over all comparisons and checked for every cluster whether it applied to this comparison. Due to the function for this being called in every comparsion during the sort method, it was slow.
Now the cluster fitting to a comparison gets added to its object on parsing the json, which takes the load from the moment where the table gets sorted