Python tests rewrite #1387
Merged
Python tests rewrite #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsaglam
added
enhancement
tsaglam
reviewed
Nov 24, 2023
languages/python-3/src/test/java/de/jplag/python3/PyhtonLanguageTest.java
Outdated
Show resolved
Hide resolved
languages/python-3/src/test/java/de/jplag/python3/PyhtonLanguageTest.java
Outdated
Show resolved
Hide resolved
|
@TwoOfTwelve Spotless fails here. Also, could you just add 1-3 sentences regarding the fixes in the PR description? |
|
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!
|
tsaglam
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite for the python language module tests with the new test syntax.
Also contains a small fix for the test library.
The code, that evaluates ignored lines based on a start and end sequence (like multi-line strings or comments) used a wrong condition in the for loop. It used the number of not yet ignored lines instead of all lines, which lead to errors, if a lot of lines were already ignored.