Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented csv export. #1385

Merged
merged 13 commits into from
Jan 12, 2024
Merged

Implemented csv export. #1385

merged 13 commits into from
Jan 12, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

Implemented csv export. Includes:

  1. An abstract csv printer that can be reused
  2. Code to output comparisons in a csv and optionally anonymize the data
  3. Cli code to activate the csv output.

Solves #1082

Kr0nox
Kr0nox requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@Kr0nox Kr0nox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small thinks I found

cli/src/main/java/de/jplag/cli/CLI.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CLI.java Show resolved Hide resolved
core/src/main/java/de/jplag/reporting/csv/comparisons/CsvComparisonOutput.java Outdated Show resolved Hide resolved
core/src/main/java/de/jplag/reporting/csv/comparisons/NameMapper.java Outdated Show resolved Hide resolved
core/src/main/java/de/jplag/reporting/csv/comparisons/NameMapperRandomIds.java Outdated Show resolved Hide resolved
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Nov 22, 2023
tsaglam
tsaglam requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few issues.

cli/src/main/java/de/jplag/cli/CLI.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CLI.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CliOptions.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CliOptions.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CliOptions.java Outdated Show resolved Hide resolved
cli/src/main/java/de/jplag/cli/CliOptions.java Outdated Show resolved Hide resolved
core/pom.xml Outdated Show resolved Hide resolved
core/src/main/java/de/jplag/csv/CsvPrinter.java Show resolved Hide resolved
core/src/main/java/de/jplag/csv/comparisons/NameMapperIncrementalIds.java Show resolved Hide resolved
tsaglam
tsaglam reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly ready to merge, just one thing we overlooked.

cli/src/main/java/de/jplag/cli/OutputFileGenerator.java Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
50.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@tsaglam
Copy link
Member

tsaglam commented Jan 12, 2024

@Kr0nox ready to merge from your side?

@tsaglam tsaglam merged commit 7167284 into develop Jan 12, 2024
9 checks passed
@tsaglam tsaglam deleted the feature/csv-mode branch January 12, 2024 11:42
@tsaglam tsaglam mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kr0nox Kr0nox Kr0nox approved these changes

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoOfTwelve @tsaglam @Kr0nox