Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhauled the end to end tests and added the test code from progpedia #1279

Merged
merged 22 commits into from
Nov 24, 2023
Merged

Overhauled the end to end tests and added the test code from progpedia #1279

merged 22 commits into from
Nov 24, 2023

Conversation

TwoOfTwelve
Copy link
Contributor

Reworked the End-to-End tests. They now use a data set descriptor to identify the sources to be tested.

Also added the progpedia code to the end to end tests.

@dfuchss
Copy link
Member

dfuchss commented Sep 13, 2023

@TwoOfTwelve could you take a look into the failing build :) ?

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Sep 26, 2023
tsaglam
tsaglam reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my generated expected test values, the E2E tests still fail, but due to:
Error: Run 4646: EndToEndSuiteTest.lambda$generateGoldStandardTest$6:214 The gold standard tests are skipped, because no gold standard is defined

@tsaglam tsaglam added this to the v5.0.0 milestone Oct 4, 2023
tsaglam
tsaglam reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a summary of the recent discussions:

  • GST changes should be separate PR
  • Datsets should be zipped due to bloat
  • End-to-end test results should use language regarding plagiarisms and non-plagiarisms and include if the value is higher or lower than expected

tsaglam
tsaglam requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

endtoend-testing/src/main/java/de/jplag/endtoend/helper/AverageCalculator.java Outdated Show resolved Hide resolved
endtoend-testing/src/main/java/de/jplag/endtoend/model/ComparisonIdentifier.java Outdated Show resolved Hide resolved
endtoend-testing/src/main/java/de/jplag/endtoend/model/ComparisonIdentifier.java Show resolved Hide resolved
endtoend-testing/src/main/java/de/jplag/endtoend/model/DataSet.java Outdated Show resolved Hide resolved
endtoend-testing/src/main/java/de/jplag/endtoend/model/DataSet.java Outdated Show resolved Hide resolved
endtoend-testing/src/main/java/de/jplag/endtoend/model/DataSet.java Outdated Show resolved Hide resolved
endtoend-testing/src/main/java/de/jplag/endtoend/model/DataSet.java Outdated Show resolved Hide resolved
This was referenced Oct 25, 2023
Closed
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2023 •
edited
Loading

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

76.1% 76.1% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam changed the title Overhauled the end to end tests and added the test code from progpedia. Overhauled the end to end tests and added the test code from progpedia Nov 24, 2023
@tsaglam tsaglam merged commit 40d466e into develop Nov 24, 2023
10 checks passed
@tsaglam tsaglam deleted the feature/endToEndTests-Rework branch November 24, 2023 13:52
@tsaglam tsaglam mentioned this pull request Dec 1, 2023
Closed
@emmanuel-ferdman emmanuel-ferdman mentioned this pull request Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

@Kr0nox Kr0nox Awaiting requested review from Kr0nox

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoOfTwelve @dfuchss @tsaglam