-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Code displaying #1275
Rework Code displaying #1275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some nitty-gritty details regarding the code view:
- Please have a look at the bug report from sonarcloud whether or not it is applicable
- Clicking on an entry from the top token list at the top should probably scroll to the code snippet in both views
- The currently selected view (left or right) gets scrolled using the scroll wheel even if the mouse is over the other side which is probably confusing to the user
Apart from that, this PR can be merged. I also noticed, that at least for me, the current version of the code view of the develop
branch is broken.
[JPlag Report Viewer] SonarCloud Quality Gate failed. 1 Bug No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
One of them I fixed, for the other I would have said its not applicable since we are using a table as its inteded purpose to structure data (in our case code) and we dont want a header in this place. So the remaining issue is not applicable in my opinion
Chromium based browsers apperantly have a problem with smooth scrolling two divs. Edge especially since it just stops the scrolling in place. Fixed by not having smooth scrolling.
I could only reproduce this bug in Edge. All other browsers do not have this issue. Beacause of this and since it is a problem I could also reproduce on other websites having two scrollable containers (also exclusivly on edge), I would have deamed this an issue with Edge. |
[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed! |
I now what the error is. I could do a fixing PR. On the other hand these changes in the PR would be overwritten by this one anyways. |
This PR reworks the components involved in code displaying, to improve code quality and fix some bugs. It also improved the code in some other areas.
The following bugs have been fixed:
We no longer highlight every line individually (
LineOfCode.vue
) and rather highlight the entire code inCodePanle.vue
. Here we now display the code and line numbers in a table to ensure that all lines start at the indetation.Storing matches and the connection scrolling to the matching Match have been simplified alot, by not storing a component to scroll to, but rather having the components expose a function for scrolling to a certain file/line