Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to report viewer code styling #1264

Merged
merged 3 commits into from
Aug 30, 2023
Merged

Updates to report viewer code styling #1264

merged 3 commits into from
Aug 30, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Aug 29, 2023

This PR adds sorting of the tailwind classes through prettier.

In addition the pre commit hook now also effects JavaScript, HTML and CSS which it previosly did not.

@Kr0nox Kr0nox requested a review from sebinside August 29, 2023 11:31
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

[JPlag Report Viewer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sebinside
sebinside approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kr0nox I approved all assigned PRs (minus that one with the buggy radar chart); please feel free to merge them in your preferred order.

@Kr0nox Kr0nox merged commit 0fb93d8 into develop Aug 30, 2023
26 checks passed
@Kr0nox Kr0nox deleted the report-viewer/prettier-tailwind branch August 30, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebinside sebinside sebinside approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kr0nox @sebinside