Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusted behavior, default values and naming of MergingParameters #1251

Merged
merged 7 commits into from
Aug 22, 2023
Merged

Adjusted behavior, default values and naming of MergingParameters #1251

merged 7 commits into from
Aug 22, 2023

Conversation

uuqjz
Copy link
Contributor

@uuqjz uuqjz commented Aug 20, 2023

This PR does 3 things:

  1. Change mergeBuffer from being relative to MTM to an absolute Value
  2. Set sensible default values for mergeBuffer and seperatingThreshold
  3. Rename mergeBuffer to neighborLength and separatingThreshold to gapSize

@uuqjz uuqjz marked this pull request as ready for review August 20, 2023 07:54
tsaglam
tsaglam requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few thoughts regarding the naming.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Aug 22, 2023
@sonarqubecloud
Copy link

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@uuqjz uuqjz requested a review from tsaglam August 22, 2023 07:35
@tsaglam tsaglam merged commit 9564fe3 into jplag:develop Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uuqjz @tsaglam