Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement version info #1240

Merged
merged 8 commits into from
Aug 21, 2023
Merged

implement version info #1240

merged 8 commits into from
Aug 21, 2023

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Aug 15, 2023

Solves #1001
In the FileUploadView in the bottom right corner the user gets a small info text about the current version (either version number, reference to the newest version or that is a development version (0.0.0)).

With this the Alert about using the develoment version was also removed, since it is now indicated in the FileUploadView directly.

The version type was modified to be a class that has usefull functions (like comparing versions and printing them as strings) to clean up the code

@Kr0nox Kr0nox requested a review from sebinside August 15, 2023 12:19
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Aug 15, 2023
Copy link
Member

@sebinside sebinside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the simple solution, thank you. There are only two minor comments. Besides that, you can merge this PR after resolving the conflicts.

report-viewer/src/model/Version.ts Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

[JPlag Report Viewer] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
17.0% 17.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sebinside sebinside merged commit 6bdcc29 into develop Aug 21, 2023
25 of 26 checks passed
@sebinside sebinside deleted the report-viewer/minimalVersion branch August 21, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants