Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the token to line mapping for the EMF language and the Emfatic views #1227

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Aug 8, 2023

Previously, some tokens were not mapped correctly to the corresponding lines in the Emfatic code, thus leading to an incorrect match display in the report viewer. This PR fixes these issues and introduces more tests for the EMF language.

@tsaglam tsaglam changed the base branch from main to develop August 8, 2023 14:24
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Aug 8, 2023
@tsaglam tsaglam marked this pull request as ready for review August 8, 2023 14:34
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

73.5% 73.5% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit f366b76 into develop Aug 9, 2023
24 checks passed
@tsaglam tsaglam deleted the fix/emfatic-mapping branch August 9, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant