Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the java tests to use the new test framework #1204

Merged
merged 5 commits into from
Aug 5, 2023
Merged

Updated the java tests to use the new test framework #1204

merged 5 commits into from
Aug 5, 2023

Conversation

TwoOfTwelve
Copy link
Contributor

This PR updates the java tests to use the new test framework and also adds a new tests using the CLI class from jplag, to have a more complex test case.

I also fixed a small bug in the language framework, where the TRY_END token was added to early.

@TwoOfTwelve
Copy link
Contributor Author

@tsaglam Could you take a look at this? One of the java tests fails, because the similarity is slightly different. This is probably, because I changed the order of the try-catch tokens. I think that discrepancy fine, but I would like you to judge that.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Aug 4, 2023
tsaglam
tsaglam requested changes Aug 4, 2023
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you try to preserve the documentation? Makes it easier to read. Se comments below.
Test values seem fine. As discussed, adapt the expected values in another commit.

languages/java/src/test/java/de/jplag/java/JavaBlockTest.java Show resolved Hide resolved
languages/java/src/test/java/de/jplag/java/JavaIfElseTest.java Show resolved Hide resolved
languages/java/src/test/java/de/jplag/java/JavaTryTest.java Show resolved Hide resolved
languages/java/src/test/java/de/jplag/java/JavaLanguageTest.java Show resolved Hide resolved
@TwoOfTwelve
Preserve old documentation for java tests
b6e2bfb
@TwoOfTwelve
Adjusted values for base functionality test because of the changes in: …
0efc559 
…597d0fc

In that commit the order of the tokens for try-catch statements was adjusted, that for the similarities are slightly different.
@sonarcloud
Copy link

sonarcloud bot commented Aug 5, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit 3ef79f0 into develop Aug 5, 2023
24 checks passed
@tsaglam tsaglam deleted the feature/java-language-tests branch August 5, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TwoOfTwelve @tsaglam