Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded the language-antlr-utils to allow the extraction of semantic… #1177

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

TwoOfTwelve
Copy link
Contributor

Adds the option to extract semantics information to the AbstractAntlrListener. For an example how to use, take a look at the tests in language-antlr-utils.

@tsaglam tsaglam requested a review from brodmo July 6, 2023 09:18
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Jul 6, 2023
Copy link
Contributor

@brodmo brodmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how this framework pans out in practice, but I think I'll just make adjustements myself if needed.

@TwoOfTwelve
Copy link
Contributor Author

I know, that there are still some builder methods missing, but I think it is easier to add them, one you need them. I tried to base this on how the java module uses the semantics. If you think I missed something big, I can always change the framework.

The attempt was to keep everything as simple and concise as possible while keeping it flexible.

@brodmo
Copy link
Contributor

brodmo commented Jul 10, 2023

I can't really make a call on the framework until I've tried using it. I think you can merge @tsaglam

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues we need to address.

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.3% 77.3% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit 8a6e8ac into develop Jul 10, 2023
@tsaglam tsaglam deleted the antlr-utils-semantics branch July 10, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants