Feature/adopt python grammar fixes #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This solution uses the python3 grammar from the official ANTLR repository. |
This comment was marked as outdated.
This comment was marked as outdated.
tsaglam
reviewed
May 15, 2023
languages/python-3/src/main/java/de/jplag/python3/grammar/Python3LexerBase.java
Outdated
Show resolved
Hide resolved
languages/python-3/src/test/java/de/jplag/python3/PythonLanguageCoverageTest.java
Outdated
Show resolved
Hide resolved
tsaglam
added
bug
tsaglam
approved these changes
May 22, 2023
|
@TwoOfTwelve only the sonar code smells left; then I can merge. |
|
Kudos, SonarCloud Quality Gate passed! |
tsaglam
approved these changes
May 23, 2023
6 tasks
|
@TwoOfTwelve did this PR change the supported language version of Python? Or is it still 3.6? |
|
It is still 3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#280
This pr replaces the antlr grammar taken from bkiers/python3-parser by the one provided in the official antlr repositories. Both implementations follow the same general structure and all changes mentioned in (#280) seem to be present in the new grammar to.
There are also new tests for the python language module, which work with the old implementation as well as the new one. Sonarcloud does report some code smells in the grammar, but I think, it is better to leave that code as it is in the official repository.