Add SCXML language module

[smjonas]

Adds support for statecharts defined in the SCXML format.

[dfuchss]

-> https://github.com/jplag/JPlag/pull/1030/files#diff-14540919135aab6b48f03e8a03ab015774bec6c85717f42c97fe1df242222414R11

[tsaglam]

@smjonas, there are a few issues you need to resolve.

[tsaglam]

You extend the parser adapter. Thus this class is still functionally a full parser adapter. The name and comment, however, do not reflect that. Could you elaborate on the design here?

[tsaglam]

@smjonas, please also fix the build error and apply spotless. If there are any issues, let me know.
Since now I left a review, avoid force pushes.

[dfuchss]

Additionally the tests build (javadoc) needs to be fixed :)

[tsaglam]

@smjonas after you implemented our feedback, take a look at the code smells detected by Sonar and fix them! 👍

[smjonas]

@tsaglam The remaining detected code smell seems to be a false-positive as the explicit constructor performs additional checks

[dfuchss]

@tsaglam The remaining detected code smell seems to be a false-positive as the explicit constructor performs additional checks

Maybe sonarlint is just complaining about the redundancy of the parameters. In records you can omit the parameters (and brackets) of the default constructor. E.g., https://www.baeldung.com/java-records-custom-constructor (3.)

[smjonas]

I tried to change it to

    /**
     * Constructs a new state.
     * @throws IllegalArgumentException if {@code transitions} or {@code substates} is null
     */
    public State {
        if (transitions == null) {
            throw new IllegalArgumentException("State.transitions must not be null");
        }
        if (substates == null) {
            throw new IllegalArgumentException("State.substates must not be null");
        }
        updateTimedTransitions();
    }

but that won't work because updateTimedTransitions requires all variables to be initialized. So unless anyone has a better idea how to ensure that updateTimedTransition is called during instance construction, I'll have to leave the code in its current state (which is

    /**
     * Constructs a new state.
     * @throws IllegalArgumentException if {@code transitions} or {@code substates} is null
     */
    public State(String id, List<Transition> transitions, List<State> substates, List<Action> actions, boolean initial, boolean parallel) {
        if (transitions == null) {
            throw new IllegalArgumentException("State.transitions must not be null");
        }

        if (substates == null) {
            throw new IllegalArgumentException("State.substates must not be null");
        }

        this.id = id;
        this.transitions = transitions;
        this.substates = substates;
        this.actions = actions;
        this.initial = initial;
        this.parallel = parallel;
        updateTimedTransitions();
    }

).

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

91.0% Coverage
1.5% Duplication

[dfuchss]

Seems to be false positive. I'll mark it that way.