Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent changing the Java token sequence via changing if-else statements. #1003

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Mar 31, 2023

  • Ensure that if-else, if-if, and if-else-if statements generate the same combination of if and if-end tokens in the Java language module.
  • Adapt test cases to the changed behavior of the Java language module.
  • Adapt expected values of end-to-end test cases.
  • Internal evaluation with larger real-world data sets.

@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Mar 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam marked this pull request as ready for review April 17, 2023 14:24
@tsaglam tsaglam requested review from a team April 17, 2023 14:24
@tsaglam tsaglam merged commit 79edb33 into develop Apr 18, 2023
@tsaglam tsaglam deleted the bug/if-else-if branch May 16, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant