variable folding #28
Open
variable folding #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpd002
reviewed
Jun 10, 2020
| bool src1cst = statement.src1.get()->GetSymbol().get()->IsConstant(); | ||
| bool src2cst = statement.src2.get()->GetSymbol().get()->IsConstant(); | ||
|
|
||
| if(src1cst || src2cst || !statement.src1.get()->Equals(statement.src2.get())) continue; |
There was a problem hiding this comment.
I'm not very good with logical expressions, so I just want to make sure I understand properly :)
This function transforms statements that have the same non-constant src1 and src2 operands?
There was a problem hiding this comment.
yes, (checking if they're constant is easier then checking if they're !(rel || reg || tmp)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
few patterns I've noticed that can be simplified, I couldn't detect any notable improvement, but this should in theory make constant propagation more efficient