Skip to content

fix: use dynamic import instead of require#2

Merged
jpchev merged 1 commit intojpchev:fix/issue_30131from
open-craft:jill/jpchev/fix/issue_30131
Jan 24, 2025
Merged

fix: use dynamic import instead of require#2
jpchev merged 1 commit intojpchev:fix/issue_30131from
open-craft:jill/jpchev/fix/issue_30131

Conversation

@pomegranited
Copy link

fix: use dynamic import instead of require to load language file for registerLocale

and moves the import into the useEffect, so it can be loaded asynchronously.

to load language file for registerLocale.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@jpchev
Copy link
Owner

jpchev commented Jan 24, 2025

@pomegranited thank you for your commit

@jpchev jpchev merged this pull request into jpchev:fix/issue_30131 Jan 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants