Add *actual* shallow waterfill #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only normal and deep water were supported (normal water was mistakenly called "shallow")
I only know Russian, English and Japanese, so I did this with the help of DeepL. I did my best to make sure it's correct, but I may have made some mistakes. For most languages, I didn't write a description for the new setting as I have no confidence in getting that right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, only normal and deep water were supported (normal water was mistakenly called "shallow").
Since there are more than 4 valid states now (waterfill off, waterfill on, deep waterfill on, normal waterfill on), I changed waterfill to have 4 checkboxes instead of a checkbox and a dropdown. This means any people who update the mod will have the setting reset, as Factorio doesn't support mod setting migrations.
I could switch it to just 3 checkboxes instead (enable shallow/normal/deep waterfill) instead of 4 (enable waterfill + enable shallow/normal/deep waterfill). Additionally, perhaps "regular" would be better than "normal", I don't know.
I only know Russian, English and Japanese, so I did the translation changes with the help of DeepL. I did my best to make sure it's correct, but I may have made some mistakes.
For most languages, I didn't write a description for the new settings as I have no confidence in getting that right.
Also, is there a reason you only allow some waterfill with Alien Biomes enabled?