Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test stuff. #95

Merged
merged 1 commit into from
Feb 20, 2015
Merged

Include test stuff. #95

merged 1 commit into from
Feb 20, 2015

Conversation

ralphbean
Copy link
Contributor

These are also nice to have. :)

Cheers!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 02d855c on ralphbean:master into 451004e on jpadilla:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 02d855c on ralphbean:master into 451004e on jpadilla:master.

@jpadilla
Copy link
Owner

@ralphbean not sure about this one though. What's the benefit usecase for distributing tests in the package?

@ralphbean
Copy link
Contributor Author

not sure about this one though.

No hard feelings if you're not interested.

What's the benefit usecase for distributing tests in the package?

Primarily for third-parties who want to rebuild the package for distribution (linux distributions, companies with their own caches of pypi packages). In my case, this is for Fedora Linux -- we like to run the test suites automatically before we build tarballs into RPMs. Debian and others like to do this too when possible.

It's possible for us to clone the repo and copy the tests from there along with the PyPI release, but it's cumbersome and more error-prone.

@jpadilla
Copy link
Owner

@ralphbean valid, and definitely makes sense for this type of utility package.

Sold!

jpadilla added a commit that referenced this pull request Feb 20, 2015
@jpadilla jpadilla merged commit 2d0e827 into jpadilla:master Feb 20, 2015
@ralphbean
Copy link
Contributor Author

✨ 🌊 Thanks! 🌊 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants