Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import collection ABC's from correct module #375

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

kreutz-hs
Copy link
Contributor

They were moved into collections.abc in 3.3 and will be deprecated
from collections in 3.8.

 * Import collection ABC's from correct module
   They were moved into collections.abc in 3.3 and will be deprecated
   from collections in 3.8.
@jaraco
Copy link
Contributor

jaraco commented Nov 1, 2018

This fixes #381.

@kreutz-hs
Copy link
Contributor Author

So what does it mean? Somebody has apparently added tests that require that there will be a deprecation warning. ???
Those tests now fail this merge request.

Should I do something?

@jpadilla
Copy link
Owner

jpadilla commented Nov 2, 2018

@kreutz-hs all good now, thanks!

@kreutz-hs
Copy link
Contributor Author

OK, cool! Thanks for all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants