PyJWT.decode: move verify param into options #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
PyJWT.decode-fix-deprecation
branch
from
bb04ad8
to
947c8c1
Compare
|
Please let me know if I understood it correctly now, and if the fixup is better than the original in your opinion. |
|
@blueyed looks good to me 👍 thanks! |
Followup to jpadilla#270: It seems that "verify" is only deprecated with `PyJWS.decode`, which makes sense, since you would have to override a lot of options to skip the verification in `PyJWT._validate_claims`. This makes `PyJWT.decode` use the `verify_signature` option when calling `PyJWT.decode`, and therefore also allows to use `stacklevel=2` there then for the DeprecationWarning.
blueyed
force-pushed
the
PyJWT.decode-fix-deprecation
branch
from
91d06b4
to
f61d37f
Compare
|
@jpadilla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #270:
It seems that "verify" is only deprecated with
PyJWS.decode, whichmakes sense, since you would have to override a lot of options to skip
the verification in
PyJWT._validate_claims.This makes
PyJWT.decodeuse theverify_signatureoption when callingPyJWT.decode, and therefore also allows to usestacklevel=2therethen for the DeprecationWarning.