RSA-PSS should use the proper salt value when creating and verifying signatures #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors from RFC 7520
… for the salt length instead of the maximum salt length per the JWA spec. Fixes jpadilla#162.
|
@mark-adams would you look at that! Great idea using those test vectors from the RFC. Merge this whenever you like. |
mark-adams
added a commit
that referenced
this pull request
May 22, 2015
RSA-PSS should use the proper salt value when creating and verifying signatures
This was referenced Aug 22, 2016
This was referenced Sep 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added the RFC 7520 test vectors to our project, the RSA-PSS algorithm test would not pass.
After further review, it turns out that I improperly implemented this originally. JWA clearly specifies how the salt length should be set:
This PR corrects that issue and removes some redundant tests from our original test suite for algorithms since the RFC 7520 tests accomplish the same thing.