Revert "util: Spoof Ada and later GPUs as Ampere for Ghost of Tsushima" #219
+0
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, PR is good ofc. Would be nice if the commit message at least briefly states why we don't need this any longer. |
jp7677
approved these changes
Nov 2, 2024
This reverts commit f86f56b. The issue was caused by DLSS-FG being in theory supported by reported hardware but the system / Wine environment failing required checks (hardware scheduling and nvofapi), making the game enter a half-broken state where it tripped over its own present calls. This should no longer be the case, at least in Proton.
Saancreed
force-pushed
the
revert-got-workaround
branch
from
9fe8d5d
to
2bd411d
Compare
|
The workaround was made for a reason, are we sure it isn’t needed? |
|
@shelterx The cause of this issue will be gone from Proton soon so yes, we are… fairly confident about it. But feel free to verify this and report back; while I can no longer notice the problem myself, another confirmation would be appreciated. Just don't forget to add Liam's D3DKMT patches to the mix and install nvofapi64.dll into Proton prefix. |
|
@Saancreed seems to work yes from what I could tell, with DLSS FG and Reflex On |
|
That's great, thanks for checking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f86f56b.
To be merged after DLSS FG support is in place. Let me know if I should actually write a new commit message.