Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ascii #187

Merged
merged 23 commits into from
Mar 5, 2021
Merged

Test ascii #187

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3fb96f7
Add all ASCII characters
Mar 3, 2021
dece32e
Reproduced #186 with a longer line
A9G-Data-Droid Mar 3, 2021
13cfd5e
New StringHasUnicode closes #186
A9G-Data-Droid Mar 4, 2021
aa1afe3
Export with BOM always false
A9G-Data-Droid Mar 4, 2021
9aea695
New Encoding method
A9G-Data-Droid Mar 4, 2021
4e8b977
Replace DLL calls with native functions
A9G-Data-Droid Mar 4, 2021
fa42593
Replace DLL calls with native functions
A9G-Data-Droid Mar 4, 2021
b7f73d1
Always write UTF8 with BOM
A9G-Data-Droid Mar 5, 2021
7c53791
Make FileHasBom look more like the original
A9G-Data-Droid Mar 5, 2021
a473eb5
Use ReadFile and GetFileBytes
A9G-Data-Droid Mar 5, 2021
d5f4c19
Export using latest version
A9G-Data-Droid Mar 5, 2021
043cc68
Remove copyrighted content
Mar 5, 2021
a3b8a28
ReUse existing converters
A9G-Data-Droid Mar 5, 2021
1bd7460
Oops, use Unicode instead of autodetect
A9G-Data-Droid Mar 5, 2021
9c8b5ac
Merge branch 'testASCII' of https://github.com/A9G-Data-Droid/msacces…
A9G-Data-Droid Mar 5, 2021
09e610e
Ignore all log files
Mar 5, 2021
247f3b4
Move file reading and writing functions to correct module
Mar 5, 2021
abc6c7c
Retool encoding functions
Mar 5, 2021
51f0b59
Remove testing code
Mar 5, 2021
75ced35
Add constant for chunk size
Mar 5, 2021
2c98da1
Improve performance logging
Mar 5, 2021
f98ce48
Increment build number
Mar 5, 2021
d16abbb
Update testing database
Mar 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Testing/Testing.accdb.src/dbs-properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
"Type": 4
},
"ProjVer": {
"Value": 119,
"Value": 142,
"Type": 3
},
"QueryTimeout": {
Expand Down
243 changes: 240 additions & 3 deletions Testing/Testing.accdb.src/modules/basExtendedChars.bas
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 1 addition & 15 deletions Testing/Testing.accdb.src/nav-pane-groups.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,25 +6,11 @@
},
"Items": {
"Categories": [
{
"Name": "Custom",
"Flags": 0,
"Position": 3,
"Groups": [
]
},
{
"Name": "My Category",
"Flags": 0,
"Position": 2,
"Groups": [
{
"Name": "Unassigned Objects",
"Flags": 4,
"Position": 1,
"Objects": [
]
},
{
"Name": "Macros & Reports",
"Flags": 0,
Expand Down Expand Up @@ -77,7 +63,7 @@
{
"Name": "Unassigned Objects",
"Flags": 4,
"Position": 3,
"Position": 1,
"Objects": [
]
}
Expand Down
2 changes: 1 addition & 1 deletion Testing/Testing.accdb.src/reports/rptDefaultPrinter.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Begin Report
Width =8884
DatasheetFontHeight =11
ItemSuffix =1
DatasheetGridlinesColor =14806254
DatasheetGridlinesColor =15132391
RecSrcDt = Begin
0xe05ff061b477e540
End
Expand Down
4 changes: 2 additions & 2 deletions Testing/Testing.accdb.src/reports/rptNavigationPaneGroups.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Begin Report
Width =11700
DatasheetFontHeight =11
ItemSuffix =7
DatasheetGridlinesColor =14806254
DatasheetGridlinesColor =15132391
RecSrcDt = Begin
0x2df649898e77e540
End
Expand Down Expand Up @@ -74,7 +74,7 @@ Begin Report
Begin FormHeader
KeepTogether = NotDefault
Height =960
BackColor =15849926
BackColor =15064278
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A9G-Data-Droid, @joyfullservice: This is what I was experiencing on #183, have you noticed this? Any clues as to what the heck is happening?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to do with exporting in different versions of Access? I notice this when comparing exports from Access 2010 and newer versions... I haven't actually dug into comparing the color values.

Copy link
Contributor

@hecon5 hecon5 Mar 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure! I noticed it when me and another dev were exporting the same file (export-import-export) on the same machine will sometimes do this, from their dev machine export - mine import - mine export will almost always cause this.
We verified same OS and Office Version, as well; so this makes it more fun.

Note that we use themes; I'm wondering if this might have something to do with it; but I notice it also when I export the Version Control as well, too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens to me every time. Themes might be a clue. Most colors are not defined as a concrete number. Instead they are references to the system colors. Things like "Text Dark", "Text Light", "Background Dark Header" and "Background Light Header" come from Windows system settings and do not correspond to the same RGB value on every computer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, I didn't ask the other dev if they're using the same Windows Theme; I'll check with them. I could also export, change my theme, import, export.

Name ="ReportHeader"
AutoHeight =1
AlternateBackThemeColorIndex =1
Expand Down
2 changes: 1 addition & 1 deletion Testing/Testing.accdb.src/reports/rptNonDefaultPaperSize.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Begin Report
Width =8884
DatasheetFontHeight =11
ItemSuffix =1
DatasheetGridlinesColor =14806254
DatasheetGridlinesColor =15132391
RecSrcDt = Begin
0xe05ff061b477e540
End
Expand Down
5 changes: 2 additions & 3 deletions Testing/Testing.accdb.src/vbe-project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
{
"Info": {
"Class": "clsDbVbeProject",
"Description": "VBE Project",
"VCS Version": "3.1.25"
"Description": "VBE Project"
},
"Items": {
"Name": "VCS Testing",
"Description": "For automated testing of Version Control",
"FileName": "rel:Testing.accdb",
"HelpFile": "",
"HelpFile": "99672516",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hecon5 this is even more mysterious than the colors changing. I get random numbers in this HelpFile property every time I export. I never change this value manually. It should be a path. I'm not sure where this number is being introduced.

You can see it from the VBE by going to the Project Properties:

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAME! It has repeatedly boggled me; I've simply reverted it and moved on with my life, but yeah; no idea why it does this. I'll even occasionally get kanji characters there, but cannot for the life of me figure it out.

"HelpContextId": 123456,
"Mode": 0,
"Protection": 0,
Expand Down
4 changes: 2 additions & 2 deletions Testing/Testing.accdb.src/vcs-options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"Info": {
"AddinVersion": "3.2.3",
"AccessVersion": "14.0 32-bit"
"AddinVersion": "3.3.3",
"AccessVersion": "16.0 64-bit"
},
"Options": {
"ExportFolder": "",
Expand Down
6 changes: 3 additions & 3 deletions Version Control.accda.src/dbs-properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"Type": 10
},
"AppVersion": {
"Value": "3.3.6",
"Value": "3.3.3",
"Type": 10
},
"Auto Compact": {
Expand Down Expand Up @@ -117,7 +117,7 @@
"Type": 4
},
"ProjVer": {
"Value": 119,
"Value": 142,
"Type": 3
},
"QueryTimeout": {
Expand Down Expand Up @@ -197,7 +197,7 @@
"Type": 2
},
"Version": {
"Value": "14.0",
"Value": "12.0",
"Type": 12
},
"WebDesignMode": {
Expand Down
Loading