Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apostrophe in table name #83

Closed
effjot opened this issue Oct 29, 2020 · 2 comments
Closed

Apostrophe in table name #83

effjot opened this issue Oct 29, 2020 · 2 comments

Comments

@effjot
Copy link
Contributor

effjot commented Oct 29, 2020

Export of tables fails if the name contains apostrophes.

I‘ve addded a fix to export and TDF table data import (https://github.com/effjot/msaccess-vcs-integration/tree/export-import-tablename-with-apostrophe), which seems to work.
Such names are a bit deep in Bobby Tables land… Other quoting issues still may lurk somewhere else. Probably it’s better to not allow apostrophes at all.

I only stumbled across it after forgetting to delete an “import failures” table Access puts in the DB when import from Excel etc. fails.

@joyfullservice
Copy link
Owner

Thanks for pointing this out! I have updated several places in the code, and tested some interesting table and field names... 😄

image

Let me know if you encounter any further issues of this kind.

@effjot
Copy link
Contributor Author

effjot commented Oct 30, 2020

You’ve missed 1 place I had fixed (importing tdf data). I’m preparing a pull request

joyfullservice added a commit that referenced this issue Oct 31, 2020
A couple more places to fix for names to be properly handled. Thanks, @effjot for pointing out the one I missed, and @Indigo744 for highlighting the issue with the pseudo index. I believe both of these should be resolved now, but let me know if you encounter anything else!. See #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants