Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ampersand (&) in the name of a Table Index hangs VCS 3.4.17 during Export #314

Closed
alanv73 opened this issue Apr 6, 2022 · 2 comments
Assignees
Labels

Comments

@alanv73
Copy link

alanv73 commented Apr 6, 2022

Discovered a scenario where an ampersand (&) was used in the Name of a Table Index and it was causing VCS 3.4.17 to hang during export.

table_index

@joyfullservice
Copy link
Owner

Interesting! I did some testing, and it looks like the underlying issue is that the native Microsoft Access .SaveAsXML function does not properly encode the ampersand.

By default Microsoft Access produces the following:

image

Technically, this is not valid XML. It fails an online validator, and triggers an error during the parse by the SAXXMLReader60 object in the FormatXML function.

If you change & to & it parses and imports just fine.

image

I will go ahead and add some VBA code to properly encode any ampersands that exist in the XML file, and also add some error handling to the XML parser so it will log an error and fall back to the original XML if something like this comes up in the future.

Thanks again for reporting this!

joyfullservice added a commit that referenced this issue Apr 6, 2022
The XML output for a table def from Microsoft Access does not correctly encode the ampersand character. This creates XML that is technically invalid, and later fails to parse. #314
joyfullservice added a commit that referenced this issue Apr 6, 2022
Added error handling to manage XML content that cannot be parsed. The raw XML will be dumped into the log file for further inspection. #314
@joyfullservice joyfullservice self-assigned this Apr 6, 2022
joyfullservice added a commit that referenced this issue Apr 6, 2022
The XML output for a table def from Microsoft Access does not correctly encode the ampersand character. This creates XML that is technically invalid, and later fails to parse. #314
@joyfullservice
Copy link
Owner

Added fixes to the master and dev branches.

joyfullservice added a commit that referenced this issue May 20, 2022
I found another edge case for HTML special entities where embedded quotes in the default value of a field were being sanitized incorrectly.  #314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants