Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clsConcat: Error if GetStr ist a multiple of 4096 #194

Closed
Tanarri opened this issue Mar 11, 2021 · 3 comments
Closed

clsConcat: Error if GetStr ist a multiple of 4096 #194

Tanarri opened this issue Mar 11, 2021 · 3 comments
Assignees

Comments

@Tanarri
Copy link
Contributor

Tanarri commented Mar 11, 2021

I had exported my big project several times with no problem, but today I got one with version 3.3.13
Please turn on debugging mode in VCS, otherwise the error will be not shown

With a additional debugging tool (vbWatchdog https://www.everythingaccess.com/vbwatchdog.asp ) I tracked it down to following line of code in clsConcat which fail:
Mid$(GetStr, (lngCnt * clngPageSize) + 1, clngPageSize) = astrPages(lngCnt)

The variables contents are on start of the procedure:
The string "GetStr" will be initialised with length 53248
grafik

And in the 13th interation:
A assignment will performed on position 53249 (1 past the end of initial string "GetStr") which results in Error 5

?Err.number, Err.Description
5 Ungültiger Prozeduraufruf oder ungültiges Argument (Propagate to 'MSAccessVCS.modVCSUtility.SaveComponentAsText')

grafik

The error is skipped when debugging is turned off, but should still be fixed.

@joyfullservice joyfullservice self-assigned this Mar 12, 2021
joyfullservice pushed a commit that referenced this issue Mar 12, 2021
Resolved several issues in the concatenation class. The intended functionality now works where you can set the page size and default pages, and a paging bug has been fixed. I also added some additional checks to the `SelfTest` function to ensure that it is paging correctly. Closes #194
@joyfullservice
Copy link
Owner

Thanks for reporting this! I have just pushed an update that should resolve this issue. Let me know if you encounter any further problems with the concatenation class.

@joyfullservice
Copy link
Owner

Sounds like we still have a little more to do on this, as noted in #195. I will try to look at this on Monday, unless someone else wants to offer a pull request before then.

joyfullservice added a commit that referenced this issue Mar 15, 2021
* Update modUnitTesting.bas

Added Test for clsConcat

* Update clsConcat.bas

Add more tests to clsConcat. This test will show a error, which has to be solved.

* Update clsConcat.bas

fix #194
update Tests in #195

Co-authored-by: Adam Waller <[email protected]>
@joyfullservice
Copy link
Owner

Thanks for the PR! It appears to have solved the issue, so I will go ahead and close this out. Feel free to reopen if anything further comes up. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants