Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panji-Satria #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Panji-Satria #6

wants to merge 3 commits into from

Conversation

panji-sn
Copy link

@panji-sn panji-sn commented Nov 3, 2019

.env
SALT=2
SECRET="FancyToDo"
GOOGLE_CLIENT_ID='291856601506-pctu3kf6427nn8527jqa0a9tlv5i1s7f.apps.googleusercontent.com'
MONGOOSE_URL='mongodb://localhost/FancyToDo'
WEATHER_API_KEY=91df2eb8b58b2d1d29e0f869d4fe46ee

@panji-sn
Copy link
Author

panji-sn commented Nov 4, 2019

Link Deploy
http://fancytodo.panji-h8.online/

@dhimashary
Copy link

  • tampilan weathernya bisa dibikin lebih rapi lagi , sehingga tidak perlu scroll hanya untuk lihat data cuacanya
  • Form create todo di reset jika selesai submit
  • done undone ketika edit todo bagusnya tidak tampil berbarengan (pakai kondisional)
  • add member masih buggy, bisa add member yang sudah ada
  • add member baiknya input type email aja, jadi invite member lain via ketik emailnya, jangan di populate dari awal

}
})
.then (() => {
arrTemp.push(addMember)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ga ada di cek apakah member sudah ada atau belum

if (result.OwnerId == OwnerId) {
return true
} else {
err = new Error (`You're unathorized to add member`)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ini kenapa ga di middleware

})
.catch (() => {
let err
err = new Error('Data Not Found')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catch disini kan errornya bukan karena data not found

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(catch controller yg lain jg ya)

let arrTemp = []
Project.findById(id)
.then (result => {
for (let i = 0; i < result.ToDoId.length; i++) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coba baca yang match an array disini https://docs.mongodb.com/manual/tutorial/query-arrays/

})
.then (data => {
if (data.length > 0) {
for (let el in data) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

})
}

static updateStatus (req, res, next) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update status dan update todo bisa jadi 1

res.status(200).json({token})
})
.catch (() => {
err = new Error('Login Failure, Something Wrong With Connection')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

di next aja errornya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants