This repository has been archived by the owner on May 4, 2018. It is now read-only.
WIP: uv_fs_[fl]stat should support subsecond resolution #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| uv_timespec_t st_atim; | ||
| uv_timespec_t st_mtim; | ||
| uv_timespec_t st_ctim; | ||
| #if defined(__POSIX__) |
There was a problem hiding this comment.
Drop the conditional and zero the values on Windows?
Most of the fields in this struct should probably be unsigned long or uint64_t. st_dev and st_rdev, for example, are 64 bits on 64 bits Linux. (Though it's up for debate how plausible it is to have over 2^32 devices.)
|
I've updated this, with the suggested changes, there's also a version that needs to be reviewed by @piscisaureus which must offend his taste, because it offends mine |
| dst->st_mtim.tv_nsec = src->st_mtimespec.tv_nsec; | ||
| dst->st_ctim.tv_sec = src->st_ctimespec.tv_sec; | ||
| dst->st_ctim.tv_nsec = src->st_ctimespec.tv_nsec; | ||
| #elif defined(_POSIX_C_SOURCE) /* TODO this isn't entirely accurate */ |
There was a problem hiding this comment.
#elif defined(_BSD_SOURCE) || defined(_SVID_SOURCE)?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds uv_stat_t with a consistent interface across platforms, and on platforms where it's supported ->st_mtim.tv_nsec will be populated
currently only for unix, and doesn't check if we're on a platform where it's not supported.