This repository has been archived by the owner on May 4, 2018. It is now read-only.
Add uv_try_write on windows #1464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return uv_tcp_try_write((uv_tcp_t*) stream, bufs, nbufs); | ||
| break; | ||
| default: | ||
| assert(0); |
There was a problem hiding this comment.
Let's do UV_ENOSYS trick here, not just fail :)
There was a problem hiding this comment.
I don't know what is the spec.
See https://github.com/joyent/libuv/blob/master/src/win/stream.c#L42
There was a problem hiding this comment.
There is no written spec per se, but we try to not fail so abuptly. Please return an error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.