Merged
Conversation
Contributor
|
No, it won’t automatically merge Re: static method - alright. Going with you on this. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
.commandName->.nameissue that was breaking some SMS commands.This branch is off of another as-of-yet-unmerged branch,
database-fix, that implements the ES6 singleton indatabase.js. I'm guessing that merging this one will automatically mergedatabase-fixas well?Regarding the ES6 singleton in
database.js: you had expressed some concerns about a static method being able to accessthis., but I've tested this and it works.