Skip to content

fix: address code review findings from #71 and #80#81

Merged
joshsmithxrm merged 17 commits into
mainfrom
fix/code-review-71
Jan 2, 2026
Merged

fix: address code review findings from #71 and #80#81
joshsmithxrm merged 17 commits into
mainfrom
fix/code-review-71

fix: address PR review feedback (issues 1, 3, 4)

60c9374
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jan 2, 2026 in 4s

5 new alerts

New alerts in code changed by this pull request

  • 5 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 23 in src/PPDS.Auth/Pooling/ProfileConnectionSource.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed 'using' opportunity Note

This variable is manually
disposed
Loading
in a
finally block
Loading
- consider a C# using statement as a preferable resource management technique.

Check notice on line 199 in src/PPDS.Auth/Pooling/ProfileConnectionSource.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 86 in src/PPDS.Migration/Import/DeferredFieldProcessor.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed opportunity to use Where Note

This foreach loop
implicitly filters its target sequence
Loading
- consider filtering the sequence explicitly using '.Where(...)'.

Check notice on line 85 in src/PPDS.Migration/Import/DeferredFieldProcessor.cs

See this annotation in the file changed.

Code scanning / CodeQL

Nested 'if' statements can be combined Note

These 'if' statements can be combined.

Check notice on line 208 in src/PPDS.Migration/Import/RelationshipProcessor.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.