deps: combine 12 dependabot updates + fix flaky test#668
Conversation
NuGet updates: - Microsoft.Identity.Client 4.82.1 → 4.83.1 - Microsoft.Identity.Client.Extensions.Msal 4.82.1 → 4.83.1 - Devlooped.CredentialManager 2.6.1.1 → 2.7.0 - System.Security.Cryptography.Pkcs 10.0.2 → 10.0.5 - System.CommandLine 2.0.2 → 2.0.5 - Microsoft.SqlServer.TransactSql.ScriptDom 170.3.0 → 170.191.0 - Microsoft.SourceLink.GitHub 10.0.102 → 10.0.201 - coverlet.collector 8.0.0 → 8.0.1 - FluentAssertions 8.8.0 → 8.9.0 npm updates (Extension): - knip 5.87.0 → 6.0.2 - eslint 10.0.3 → 10.1.0 - stylelint 17.4.0 → 17.5.0 - typescript-eslint 8.57.0 → 8.57.1 - flatted 3.3.3 → 3.4.2 (transitive) Fix flaky AsyncHelperTests.FireAndForget_UnwrapsAggregateException — replaced fixed Task.Delay(100) with polling loop (2s timeout) to eliminate thread-pool scheduling race under CI load. Supersedes: #635, #636, #637, #638, #639, #640, #641, #644, #645, #646, #647, #649 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the project's dependencies by combining numerous Dependabot updates into one comprehensive change. This consolidation simplifies the dependency management process and ensures all packages are brought up to their latest stable versions. Additionally, a critical fix for a previously flaky asynchronous test has been implemented, which will enhance the stability and reliability of the continuous integration pipeline by eliminating spurious failures. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
joshsmithxrm
had a problem deploying
to
test-dataverse
GitHub Actions
Error
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily updates various NuGet and npm package dependencies across the project, including updates to Devlooped.CredentialManager, Microsoft.Identity.Client, eslint, knip, stylelint, and typescript-eslint. Additionally, the PR refactors asynchronous tests in AsyncHelperTests.cs to replace fixed Task.Delay calls with a new WaitForErrors helper method, aiming to improve test reliability. Feedback suggests enhancing the WaitForErrors helper by using System.Diagnostics.Stopwatch for more reliable time measurement and adding an Assert.Fail() for clearer timeout messages.
…aitForErrors Use Stopwatch instead of Environment.TickCount64 for more reliable time measurement, and add Assert.Fail with a descriptive message on timeout for easier debugging. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joshsmithxrm
temporarily deployed
to
test-dataverse
GitHub Actions
Inactive
1 participant
Summary
FireAndForget_UnwrapsAggregateException) that was causing spurious CI failures on those PRsNuGet Updates
npm Updates (Extension)
Flaky Test Fix
AsyncHelperTests.FireAndForget_UnwrapsAggregateExceptionused a fixedTask.Delay(100)that was too short under CI thread-pool saturation. Replaced with a polling loop (25ms intervals, 2s timeout) to eliminate the race condition.Supersedes
Closes #635, #636, #637, #638, #639, #640, #641, #644, #645, #646, #647, #649
Test plan
dotnet build— 0 errors, 0 warningsdotnet test --filter "Category!=Integration"— all passing across net8.0/net9.0/net10.0typecheck— cleaneslint— 0 errors (22 pre-existing warnings)vitest— 351 tests passing🤖 Generated with Claude Code