Add createAlarm action #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfarrant
requested changes
Dec 18, 2018
There was a problem hiding this comment.
Looking great @jakebathman, thanks for taking the time to contribute!
One super tiny request then it's good to go. 🎉
regaw-leinad
approved these changes
Dec 18, 2018
|
Alrighty @joshfarrant, I addressed the feedback and rebased it on the latest If you'd like to test it (or anyone else), here's what I used: https://gist.github.com/jakebathman/b4e35565b29d11f9cf2bcf1ffc0f346d Thanks! |
|
Looks good, thanks @jakebathman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Added Actions (if relevant)
Are you happy to be listed as a contributor on Shortcuts.fun?
✅ Yes
Any other information / comments
I really appreciated the contributing guide, but did have some confusion going through the steps. I've got some notes on that and I'll make a separate PR for some updates to contributing.md. Otherwise it seemed to go alright, assuming the changes look good to you!