Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setWiFi & setCellularData actions #24

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

JB1905
Copy link
Contributor

@JB1905 JB1905 commented Nov 30, 2018

Please delete all sections in italics before submitting this PR.

Checks

  • I've checked there are no linting errors.
  • I've checked the code is still at 100% test coverage.

Added Actions (if relevant)

  • setWiFi
  • setCellularData

@joshfarrant
Copy link
Owner

Looks good again @JB1905, cheers!

I think I know the answer to this, but does the setCellularData action display in the Shortcuts app as 'Set Cellular Data'?

I only ask as it's showing as 'Set Mobile Data' for me - I'm guessing is a localisation thing as 'mobile' is definitely a British thing (my region), and 'cellular' is more American. It's not something I'd considered before now.

@JB1905
Copy link
Contributor Author

JB1905 commented Nov 30, 2018

For the USA region it's visible as 'Set Cellular Data'. Also identifier name is is.workflow.actions.cellulardata.set

img_6870

@joshfarrant
Copy link
Owner

Cool, we'll stick with that then, as there are probably more users on the US region than UK. Thanks for checking 👍

@joshfarrant joshfarrant merged commit 0cbab36 into joshfarrant:master Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants