[Canvas] Fix map embeddables not showing up on PDF reports (elastic#6…

…1149) (elastic#61345) * Allow embeddables to track their own render complete for report generation in canvas * Updating following consult with reporting team Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
joshdover · Mar 25, 2020 · eb46653 · eb46653
1 parent f91fb98
commit eb46653
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/x-pack/legacy/plugins/canvas/public/apps/export/export/export_app.js b/x-pack/legacy/plugins/canvas/public/apps/export/export/export_app.js
@@ -28,6 +28,7 @@ export class ExportApp extends React.PureComponent {
     const { workpad, selectedPageId } = this.props;
     const { pages, height, width } = workpad;
     const activePage = pages.find(page => page.id === selectedPageId);
+    const pageElementCount = activePage.elements.length;
 
     return (
       <div className="canvasExport">
@@ -39,7 +40,7 @@ export class ExportApp extends React.PureComponent {
           </div>
           {Style.it(
             workpad.css,
-            <div className="canvasExport__stageContent">
+            <div className="canvasExport__stageContent" data-shared-items-count={pageElementCount}>
               <WorkpadPage
                 isSelected
                 key={activePage.id}

diff --git a/...egacy/plugins/canvas/public/components/element_share_container/element_share_container.js b/...egacy/plugins/canvas/public/components/element_share_container/element_share_container.js
@@ -81,11 +81,15 @@ export class ElementShareContainer extends React.PureComponent {
   };
 
   render() {
+    const shouldTrackComplete = this.props.functionName !== 'embeddable';
+
     // NOTE: the data-shared-item and data-render-complete attributes are used for reporting
+    // Embeddables should be setting data-shared-item and data-render-complete on themselves
+    // so we should not be tracking them here.
     return (
       <div
-        data-shared-item
-        data-render-complete={this.state.renderComplete}
+        data-shared-item={shouldTrackComplete ? this.state.renderComplete : undefined}
+        data-render-complete={shouldTrackComplete ? this.state.renderComplete : undefined}
         className={this.props.className}
         ref={ref => (this.sharedItemRef = ref)}
       >