Merge pull request hashicorp#1771 from hashicorp/b-fix-acctest

helper/resource/testing: unit tests to cover hashicorp#1770
josharian · May 1, 2015 · 8d953ea · 8d953ea
2 parents 5d07394 + 88744d5
commit 8d953ea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/helper/resource/testing.go b/helper/resource/testing.go
@@ -266,7 +266,8 @@ func testStep(
 		}
 	}
 
-	return state, err
+	// Made it here? Good job test step!
+	return state, nil
 }
 
 // ComposeTestCheckFunc lets you compose multiple TestCheckFuncs into

diff --git a/helper/resource/testing_test.go b/helper/resource/testing_test.go
@@ -165,7 +165,10 @@ func TestTest_stepError(t *testing.T) {
 	if !mt.failed() {
 		t.Fatal("test should've failed")
 	}
-	t.Logf("Fail message: %s", mt.failMessage())
+	expected := "Step 0 error: Check failed: error"
+	if mt.failMessage() != expected {
+		t.Fatalf("Expected message: %s\n\ngot:\n\n%s", expected, mt.failMessage())
+	}
 
 	if !checkDestroy {
 		t.Fatal("didn't call check for destroy")