Refactor code server to use a single queue

Prior to this patch, the code server had two internal queues, one to track module loading and another to track on_load callbacks. This pull requests refactors the code to have a single queue, in order to fix bugs and improve maintainability. Closes erlang#7466. Closes erlang#8510.
josevalim · Aug 25, 2024 · 83ceaf7 · 83ceaf7
1 parent 34e3822
commit 83ceaf7
Show file tree

Hide file tree

Showing 3 changed files with 210 additions and 196 deletions.
diff --git a/lib/kernel/src/code.erl b/lib/kernel/src/code.erl
@@ -563,9 +563,10 @@ ensure_loaded(Mod) when is_atom(Mod) ->
                         {Binary,File,Ref} ->
                             case ensure_prepare_loading(Mod, Binary, File) of
                                 {error,_}=Error ->
-                                    call({load_error, Ref, Mod, Error});
+                                    call({load_error, Mod, Ref}),
+                                    Error;
                                 Prepared ->
-                                    call({load_module, Prepared, Mod, File, false, Ref})
+                                    call({load_ok, Prepared, Mod, File, Ref})
                             end
                     end;
                 embedded ->