Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gts and gjs preview #167

Merged
merged 2 commits into from
Jan 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ jobs:
CI: 'true'

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v2
with:
node-version: 14.x
node-version: 18.x
- name: Install yarn
run: npm install -g yarn
- name: Install dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/ember/.docfy-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ module.exports = {
]
],
plugins: [docfyWithProse],
rehypePlugins: [prism],
rehypePlugins: [() => [prism, { alias: { gts: 'ts', gjs: 'js' } }]],
sources: [
{
root: path.join(__dirname, 'dummy-docs'),
Expand Down
20 changes: 20 additions & 0 deletions packages/ember/dummy-docs/packages/ember/preview.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
---
category: ember
---

# Preview works with gts, gjs

This works

```gts preview
import Component from '@glimmer/component';

// components/hello.gjs
export default class Hello extends Component {
isThisCool = true;

<template>
Is This Cool?: {{this.isThisCool}}
</template>
}
```
6 changes: 4 additions & 2 deletions packages/ember/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
"broccoli-source": "^3.0.1",
"calculate-cache-key-for-tree": "2.0.0",
"debug": "^4.3.3",
"ember-cli-babel": "^7.26.11",
"ember-cli-htmlbars": "^6.0.1",
"ember-cli-babel": "^8.2.0",
"ember-cli-htmlbars": "^6.3.0",
"ember-cli-typescript": "^4.2.1",
"ember-get-config": "^1.0.2",
"mdast-util-to-string": "^2.0.0",
Expand Down Expand Up @@ -85,6 +85,7 @@
"broccoli-asset-rev": "^3.0.0",
"ember-auto-import": "^2.4.0",
"ember-cli": "~4.1.1",
"ember-cli-babel": "8.2.0",
"ember-cli-dependency-checker": "^3.2.0",
"ember-cli-fastboot": "^3.2.0-beta.5",
"ember-cli-fastboot-testing": "^0.6.0",
Expand All @@ -103,6 +104,7 @@
"ember-sinon": "^5.0.0",
"ember-source": "~4.1.0",
"ember-source-channel-url": "^3.0.0",
"ember-template-imports": "^4.0.0",
"ember-template-lint": "^2.18.0",
"ember-try": "^2.0.0",
"loader.js": "^4.7.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/ember/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ function hasBackingJS(chunks: DemoComponentChunk[]): boolean {
for (let i = 0; i < chunks.length; i++) {
const chunk = chunks[i];

if (chunk.ext === 'js' || chunk.ext === 'ts') {
if (['js', 'ts', 'gts', 'gjs'].includes(chunk.ext)) {
return true;
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/ember/src/plugins/preview-template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default plugin({
const demoComponents: DemoComponent[] = [];

visit(page.ast, 'code', (node: CodeNode) => {
if (['preview-template'].includes(node.meta || '')) {
if (['preview-template', 'preview'].includes(node.meta || '')) {
demoComponents.push({
name: generateDemoComponentName(
`docfy-demo-preview-${path.basename(page.meta.url)}`,
Expand Down
1,156 changes: 1,153 additions & 3 deletions yarn.lock

Large diffs are not rendered by default.

Loading