feat: Expose relative path in PageMetaData #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolechung
force-pushed
the
expose_relative_path
branch
from
8a8a488
to
37199a9
Compare
nicolechung
force-pushed
the
expose_relative_path
branch
from
37199a9
to
2866085
Compare
nicolechung
commented
Jun 22, 2023
| ```hbs | ||
| <DocfyOutput @fromCurrentURL={{true}} as |page|> | ||
| {{#if page.relativePath}} | ||
| <a href=(concat "http://some-enterpise.com/browse/" page.relativePath) |
There was a problem hiding this comment.
Note: the build breaks if I use hbs template instead of just hbs...not sure why?
josemarluedke
approved these changes
Jul 19, 2023
|
Released in V0.7.0. Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: #160
page.editUrlworks great for github, but due to the limitations of hosted-git-info it's hard to generate an editLink for on-prem instances of Gitlab, etc.This PR exposes the
relativePathwhich is not provided by the docfy service. The ember docfy service only exposes therouteinformation, which is not necessarily related to the relative path in the repo.CONTRIBUTINGwith how to run the tests inpackage/corerelativePathto the metadatarelativePath.