Fix bug where PascalCase for strings with numbers was incorrect #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DingoEatingFuzz could you rebase this branch when you have the opportunity? Thanks. |
When the AST transformer generates component invocation nodes, it would handle numbers in paths incorrectly when generating pascal case. Before: this-is-number-2 -> ThisIsNumber2 After: this-is-number-2 -> ThisIsNumber_2
DingoEatingFuzz
force-pushed
the
b-numbered-components
branch
from
04bd352
to
bcff54b
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the AST transformer generates component invocation nodes, it would handle numbers in paths incorrectly when converting to pascal case.
Before
components/this-is-number-2-><ThisIsNumber2 />After
components/this-is-number-2-><ThisIsNumber_2 />