Bug with HasRolesUuid and HasPermissionsUuid

[kslimani]

There is an issue i missed when i proposed to upgrade laravel-permission to 2.4 : role and permissions are retrieved from database by name but using also guard name. (the logic is in the Spatie Role and Permission findByName methods).

Result is, for example, when using $user->hasRole('role-name'), it request from database by name or uuid, but not guard name : this is an issue when using multiple guards.

I don't know yet how to fix this. (we could add guard name in the where condition in traits, but i dunno if it is the best way as it may be problematic to maintain).

Maybe simply drop support for checking if a user has role or permission by uuid could be a solution for fix this issue ? In fact, is checking a role by uuid instead of name usefull ?

[joselfonseca]

@kslimani hey there! have you seen anything here? have you had any issues? Is this still an issue?

Just want to see if work needs to be done here or if I can close this.

Thanks!

[kslimani]

@joselfonseca i think you can close this issue : it's been a long time and noone reported any issue (using multiple guard is not a common use case, and if required developper can modify the role uuid trait to his needs)

[joselfonseca]

Nice, Thanks! @kslimani