[OpenAI] Update init to set#182
Merged
ShivangiReja merged 12 commits intoJul 30, 2024
Merged
Conversation
ShivangiReja
commented
Jul 26, 2024
added 2 commits
July 26, 2024 11:15
added 4 commits
July 26, 2024 15:05
joseharriaga
approved these changes
Jul 29, 2024
| /// </remarks> | ||
| [CodeGenMember("ParallelToolCalls")] | ||
| public bool? ParallelToolCallsEnabled { get; init; } | ||
| public bool? ParallelToolCallsEnabled { get; set; } |
Owner
There was a problem hiding this comment.
My understanding is that ThreadRun is an output model, so none of its properties should have setters. Could you confirm with @trrwilson ?
joseharriaga
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the init to set.
The API will be updated after we merge #181 PR.