Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non-existing hooks pages #179

Closed
wants to merge 1 commit into from

Conversation

srittau
Copy link

@srittau srittau commented Jul 14, 2021

Add an "optional" flag to retrieve_data_gen() et al. that ignores 404
errors if set and generates an empty response. Set this flag when
implicitly requesting hooks with --all.

Closes: #176

Add an "optional" flag to retrieve_data_gen() et al. that ignores 404
errors if set and generates an empty response. Set this flag when
implicitly requesting hooks with --all.
@whwright
Copy link
Contributor

IMO this should be handled through exception handling logic that is (kind of) in place already:

except SystemExit:
log_info("Unable to read hooks, skipping")

Why not raise an more discrete exception so optional data like this can always be skipped over? This approach is very specific to "I used --all but hooks are optional"

@josegonzalez
Copy link
Owner

I don't see where a flag is set.

@josegonzalez
Copy link
Owner

The argument was never set so this is effectively dead code if merged. Closing, but feel free to revisit.

@srittau srittau deleted the hooks-404 branch September 2, 2024 19:22
@srittau srittau restored the hooks-404 branch September 2, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hooks page make the script exit early
3 participants